[Feat/#81] 어드민 데스크탑 레이아웃 추가 및 분리 #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 네비게이션 탑바가 있는 레이아웃과 없는 레이아웃으로 분리하였고, 데스크탑 루트 레이아웃에 react-hot-toast 추가
Closed
4 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
🎟️ PR 유형
어떤 변경 사항이 있나요?
Check List
✅ Key Changes
📢 To Reviewers
2번의 원인이 페이지 로드와 동시에 API 요청을 보내게 되는데 PrivateAxiosInstance의 intercepter에서 토큰 검증 후에 모바일 로그인 화면으로 이동시키는 것이었습니다.
일단 임시 방편으로 intercepter에서도 pathname에 따라 desktop은 desktop으로, mobile은 mobile로 이동하도록 했습니다.
이렇게 수정하면 문제점이 useAuthRedirect()에서도 이동시키고, intercepter에서도 이동시키기 때문에 똑같은 주소로 2~3번 이동시킨다는 문제가 있습니다. 추후에 로직 갈아엎어야 할 거 같네요.
📸 스크린샷
🔗 참고 자료